[US-7.2 / OBT-211] Users page uses the shared FilterBar - #21
Open
Conversation
Replace the inline search + app filter JSX with the shared FilterBar component, passing the existing search and app-filter state as props. Behavior is unchanged.
1 task
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
US-7.2 / OBT-211 — The Users page now uses the shared
FilterBarcomponent, so filtering users by app looks polished and consistent with the rest of the console.Changes
UsersPage/index.tsx: replace the inline search + app-filter JSX withFilterBar, passing the existingsearchandfilterAppstate as props and the result count asresultLabel. Removed the now-unused Select/Input/Search/Filter imports.Search and app-filter behavior is unchanged.
Type of Change
Testing
npm run typecheck— passnpm run lint— 0 errors (pre-existing ProjectsPage warning only)npm run build— pass